Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 release #1869

Merged
merged 237 commits into from
Feb 20, 2025
Merged

2025 release #1869

merged 237 commits into from
Feb 20, 2025

Conversation

notlee
Copy link
Contributor

@notlee notlee commented Nov 13, 2024

A long running feature branch for a major 2025 release of design foundation changes.

@notlee notlee temporarily deployed to origami-webs-2025-relea-qwx29w November 25, 2024 16:09 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-qwx29w November 26, 2024 09:37 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-qwx29w November 26, 2024 09:57 Inactive
frshwtr and others added 24 commits November 27, 2024 11:43
* feat: introduce o-private-foundation

* feat: introduce o-private-foundation

* backstage: Add Sass token target

* backstage: Delete oPrivateFoundation mixin use, as it does not exist

---------

Co-authored-by: Lee Moody <[email protected]>
We decided to develop using traditional demos for this package, as the dev experience is better with Sass. We do not expect users to use this package
* feat: introduce o-private-foundation

* feat: introduce o-normalise to o-private-foundation

* feat: use o-private-foundation in origami components

* feat: introduce o-private-foundation

* feat: introduce o-private-foundation

* feat: introduce o-private-foundation

* chore: revert stories to use o-normalise

* chore: remove unused mixins and prefix remaining with private

* feat: use o-private-foundation's o-normalise

* fix: fix broken imports

* fix: fix buttons

* chore: use private foundation normalise

* chore: revert typography and buttons changes

* chore: correct errors

* chore: update package-lock.json

* chore: use main scss file

* chore: use imports as final approach, include o-colors

* chore: ensure private foundation is a peerDependency

* chore: remove tsx files

* chore: remove further cases of @use

* chore: remove unecessary variable

* chore: namespace variables

* chore: ensure original o-normalise is used in demos

---------

Co-authored-by: Lee Moody <[email protected]>
Takes o3-button and refactors to work in an o2 world. Slightly
odd use of Sass/CSS Custom Properties, with Sass conditionals
used to output duplicate CSS Custom Properties which override
each other in the same declaration. This was the safest way
to reuse o3 styles by effectively replacing class names for
Sass if statements. It's also more readable and simple than o2
Sass. Despite duplicating some properties, CSS output and
performance will be improved by moving away from the Origami
Image Service for coloured icons.

Currently supports:
- Types
- Themes
- Sizes
- Icons
- Icons only

Does not yet support:
- Custom theme maps

Will not support:
- Outputting CSS granularly. There are not many buttons left in
o2 components, and bundle size is reduced overall as noted above.

Other things of note:
- `o-private-foundation-get` allows other o2 components to grab tokens directly.
- Added Metric2 variable font
* backstage: Reduce use of Sass modules to prevent errors when importing multiple times via other components.

* backstage: Update o-table to use latest o-private-foundation changes.

* backstage: Remove o-buttons as an o-tabs dependency

* backstage: Remove o-buttons as an o-header dependency

* backstage: Remove o-buttons as an o-forms peer dependency

* backstage: Throw in o-private-foundation if a token is not found

* backstage: Remove o-buttons as an o-comments dependency

* backstage: Reluctantly port custom button colour Sass, to support messaging components.

* backstage: Remove o-buttons as an o-message dependency
)

* chore: align file structure with confirmed convention

* chore: fix lint errors

* chore: add private foundation includes to sass lint config

* chore: format o-multi-select/main.scss

* fix: format files

* fix: remove engine property from package.json

* chore: remove private-foundations

* chore: update normalise path

* chore: fix lint rules

* chore: fix lint rules
* feat: introduce and use o-private-foundation/o-visual-effects

* chore: update package-lock.json

* chore: move o-visual-effects, replace broken import
@notlee notlee temporarily deployed to origami-webs-2025-relea-qwx29w November 27, 2024 11:43 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-a0geq8 February 19, 2025 10:51 Inactive
j-mes and others added 2 commits February 19, 2025 14:46
@notlee notlee temporarily deployed to origami-webs-2025-relea-a0geq8 February 19, 2025 15:16 Inactive
@notlee notlee marked this pull request as ready for review February 19, 2025 16:23
@notlee notlee requested review from j-mes and removed request for a team and ft-dependency-auto-merger February 19, 2025 16:24
Copy link
Member

@j-mes j-mes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it… REVERT!

Disclaimer: This has been reviewed countless times by myself, Lee and Ben. 😇

These components have an o3 alternative and will be deprecated.
@notlee notlee temporarily deployed to origami-webs-2025-relea-a0geq8 February 20, 2025 09:09 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-a0geq8 February 20, 2025 09:46 Inactive
@notlee notlee merged commit 2002f6d into main Feb 20, 2025
72 checks passed
@notlee notlee deleted the 2025-release branch February 20, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants